Fire - Blaine #41

Blaine206 · 2020-11-16T16:03:41Z

Media Ranker

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Describe a custom model method you wrote.	I wrote a spotlight_selection method using the max_by enum to calculate the highest voted work. This takes the most recent highest voted work and puts it at the top of the homepage.
Describe how you approached testing that model method. What edge cases did you come up with?	Still working on this. Hoping to test for instances when there are no-users, or there aren't enough works to complete the top-10 sections.
What are `session` and `flash`? What is the difference between them?	Session are cookies, they hold onto user data until something is done to end that session. Flash is more temp, it works until the page is reloaded.
What was one thing that you gained more clarity on through this assignment?	Believe I have a better understanding of how models work and are accessed. I am getting a better understanding of how tests work. Also beginning to understand bootstrap a bit, and made my first table, button, and branch this assignment. Lastly, getting a better feel for what goes where in the rails world.
What is the Heroku URL of your deployed application?	N/A

Assignment Submission: Media Ranker

Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.

Reflection

Prompt	Response
What was a custom model method you wrote? What was it responsible for doing?
Describe how you approached testing that model method. What edge cases did you come up with?
What are `session` and `flash`? What is the difference between them?
What was one thing that you gained more clarity on through this assignment?
What is the Heroku URL of your deployed application?

…d login_form view page.

jmaddox19 · 2020-11-20T22:34:05Z

Blaine’s MR Review

Media Ranker

Great work! You built a whole site users can log into, interact with, and vote to change the way things are ordered! That's a lot! I hope you've been able to celebrate this big win!

Technically the rubric would have me give you a red but the only big gap is a lack of testing, which I know you are focusing on for bEtsy and you accomplished almost all the other learning objectives (with the exception of controller filters) so a Yellow feels much more appropriate.

Functional Requirements: Manual Testing

Criteria	yes/no
Before logging in	--
1. On index page, there are at most 10 pieces of media on three lists, and a Media Spotlight	✔️
2. Can go into a work's show page	✔️
3. Verify unable to vote on a work, and get a flash message	✔️
4. Can edit this work successfully, and get a flash message	✔️
5. Can go to "View all media" page and see three lists of works, sorted by vote	✔️
6. Verify unable to create a new work when the form is empty, and details about the validation errors are visible to the user through a flash message	Flash message is there but the specific validation errors aren't surfaced to the user.
7. Can create a new work successfully. Note the URL for this work's show page	✔️
8. Can delete this work successfully	✔️
9. Going back to the URL of this deleted work's show page produces a 404 or some redirect behavior (and does not try to produce a broken view)	I get the following Rails error: `Couldn't find Work with 'id'=25`
10. Verify that the "View all users" page lists no users	✔️
Log in	--
11. Logging in with a valid name changes the UI to "Logged in as" and "Logout" buttons	✔️
12. Your username is listed in "View all users" page	✔️
13. Verify that number of votes determines the Media Spotlight	✔️
14. Voting on several different pieces of media affects the "Votes" tables shown in the work's show page and the user's show page	✔️
15. Voting on the same work twice produces an error and flash message, and there is no extra vote	✔️
Log out	--
16. Logging out showed a flash message and changed the UI	✔️
17. Logging in as a new user creates a new user	✔️
18. Logging in as an already existing user has a specific flash message	✔️

Major Learning Goals/Code Review

Criteria	yes/no
1. Sees the full development cycle including deployment, and the app is deployed to Heroku	No but not required
2. Practices full-stack development and fulfilling story requirements: the styling, look, and feel of the app is similar to the original Media Ranker	The styling is getting there, but not particularly close. I agree with your prioritization of not bothering to give time to this over the core functionality :)
3. Practices git with at least 25 small commits and meaningful commit messages	✔️

Previous Rails learning, Building Complex Model Logic, DRYing up Rails Code

Criteria	yes/no
4. Routes file uses `resources` for works	✔️
5. Routes file shows intention in limiting routes for voting, log-in functionality, and users	Users new and create actions aren't actually being used even though there are routes and controller actions for them.
6. The homepage view, all media view, and new works view use semantic HTML	✔️
7. The homepage view, all media view, and new works view use partials when appropriate	✔️ Yes! Great use of partial views for the homepage and all media page! Though there's a missed opportunity to use partials for the new and edit works pages (with a _form partial).
8. The model for media (likely named `work.rb`) `has_many` votes	✔️
9. The model for media has methods to describe business logic, specifically for top ten and top media, possibly also for getting works by some category	✔️
10. Some controller, likely the `ApplicationController`, has a controller filter for finding a logged in user
11. Some controller, likely the `WorksController`, has a controller filter for finding a work
12. The `WorksController` uses strong params	✔️
13. The `WorksController`'s code style is clean, and focused on working with requests, responses, `params`, `session`, `flash`	✔️ Yes, other than the missed opportunity of using a before filter for finding the work by id.

Testing Rails Apps

Criteria	yes/no
14. There are valid fixtures files used for users, votes, and works	No fixtures. I recommend practicing using fixtures on the next couple projects
15. User model has tests with sections on validations (valid and invalid) and relationships (has votes)
16. Vote model has tests with sections on validations (valid and invalid) and relationships (belongs to a user, belongs to a vote)
17. Work model has tests with sections on validations (valid and invalid) and relationships (has votes)	✔️ Really glad that you did take the time to practice writing thorough model tests here :D
18. Work model has tests with a section on all business logic methods in the model, including their edge cases

Overall Feedback

Overall Feedback	Criteria	yes/no
Green (Meets/Exceeds Standards)	14+ in Functional Requirements: Manual Testing && 14+ in Code Review
Yellow (Approaches Standards)	12+ in Functional Requirements: Manual Testing && 11+ in Code Review, or the instructor judges that this project needs special attention	✔️
Red (Not at Standard)	0-10 in Code Review or 0-11 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging, or the instructor judges that this project needs special attention

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality	Yes?
Perfect Indentation	✅
Elegant/Clever	✅
Descriptive/Readable	✅
Concise	(missed opportunity with controller filters)
Logical/Organized	✅

jmaddox19 · 2020-11-20T18:28:43Z

app/controllers/works_controller.rb

+  end
+
+  def show
+    @work = Work.find(params[:id])


This code is repeated in several methods, making it a great candidate for a before filter.
I encourage you to practice writing and using controller filters on the next couple Rails projects :)

Blaine206 added 26 commits November 9, 2020 14:45

Initial Rails setup

7df671c

Created Works Controller

fa8f8f6

Created Works Index View

f3a34e1

Created Home Controller/View/& Seed.rb

83a9dcd

Created User Controller & View

161263b

Migrated CreateWorks and listed works in index

5c998b6

Created User Model

dcc309c

Created Votes Controller

0849501

Created methods in Work.rb model, Homepage Inx & View

f49eedb

WIP on Nav feats in App.erb & New Method/View

05f56ef

Created form, WIP

d1c3ae9

Created work edit feat

cb19a5d

Recreated lost relationships with models, made user index/view

dd0180e

created login routes,intro to sessions: method in user controller, an…

f100f90

…d login_form view page.

Added flash to works controller. And color style

6546e8d

created work validation model tests - half failing?

51c7c2b

Login/Logout fixed and created, Current User Sense

bf25321

upvote functionality started.

03d983e

added partials to work index

89398c5

RESCUED : categories titles in partial renders

607386f

Things are working rn. W.I.P. User Index table updated

0e490b6

Calcs for hompage and work index votes fin

3522995

Added flash eo edit work controller. Sorted Home

aac3e05

Set up user show page

8126732

reset database and checked all worked.

0d69399

More model tests worked on

9fc4a33

jmaddox19 reviewed Nov 20, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fire - Blaine #41

Fire - Blaine #41

Blaine206 commented Nov 16, 2020

jmaddox19 commented Nov 20, 2020

jmaddox19 Nov 20, 2020

Fire - Blaine #41

Are you sure you want to change the base?

Fire - Blaine #41

Conversation

Blaine206 commented Nov 16, 2020

Media Ranker

Comprehension Questions

Assignment Submission: Media Ranker

Reflection

jmaddox19 commented Nov 20, 2020

Media Ranker

Functional Requirements: Manual Testing

Major Learning Goals/Code Review

Previous Rails learning, Building Complex Model Logic, DRYing up Rails Code

Testing Rails Apps

Overall Feedback

Code Style Bonus Awards

jmaddox19 Nov 20, 2020

Choose a reason for hiding this comment